Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert PR #377 manually since design tokens #396

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Sep 9, 2024

Overview

Revert #377 i.e. restore old v1 Portal message styles.

Related

Changes

  • added v1 message mixins and styles

Testing

  1. Open http://localhost:3000/components/detail/c-message--scope-portal.
  2. Verify messages are v1 style.
  3. Open http://localhost:3000/components/detail/c-form--portal.
  4. Click [Toggle Field Errors] button.
  5. Review form error (scroll to top) and field errors are v1 style.
  6. Open http://localhost:3000/trumps/detail/s-form--portal.
  7. Click [Toggle Field Errors] button.
  8. Review form error (scroll to top) and field errors are v1 style.

UI

- original v1 restored v1
message portal message - before portal message - after
c-form c-form message - before c-form message - after
s-form s-form message - before s-form message - after

@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Sep 9, 2024
@wesleyboar wesleyboar added the minor A feature in backward-compatible manner label Sep 9, 2024
@wesleyboar wesleyboar merged commit dea44a7 into main Sep 9, 2024
5 checks passed
@wesleyboar wesleyboar deleted the fix/revert-pr-377-manually-since-design-tokens branch September 9, 2024 22:08
@wesleyboar wesleyboar changed the title Fix/revert-pr-377-manually-since-design-tokens fix: revert-pr-377-manually-since-design-tokens Sep 9, 2024
@wesleyboar wesleyboar restored the fix/revert-pr-377-manually-since-design-tokens branch September 9, 2024 22:15
wesleyboar added a commit that referenced this pull request Sep 9, 2024
* fix: revert portal "traffic" colors

* fix: revert portal message styles
@wesleyboar wesleyboar changed the title fix: revert-pr-377-manually-since-design-tokens fix: revert PR #377 manually since design tokens Sep 9, 2024
wesleyboar added a commit that referenced this pull request Sep 9, 2024
* fix: revert portal "traffic" colors

* fix: revert portal message styles

* fix: revert portal form error styles

* Fix/revert-pr-377-manually-since-design-tokens (#396)

* fix: revert portal "traffic" colors

* fix: revert portal message styles

* fix: delete unrelated new file
wesleyboar added a commit that referenced this pull request Sep 9, 2024
* fix: revert portal "traffic" colors

* fix: revert portal message styles

* fix: revert portal form error styles

* Fix/revert-pr-377-manually-since-design-tokens (#396)

* fix: revert portal "traffic" colors

* fix: revert portal message styles

* fix: delete unrelated new file

* docs: v2.33.1

* chore: v2.33.1

* build: v2.33.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes user-facing behavior or feature minor A feature in backward-compatible manner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant